fix: prevent project in transaction mode from changing pooler mode #22150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No changes detected in Branching Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
1 similar comment
w3b6x9
force-pushed
the
fix/pooler-mode-transaction
branch
from
d316424
to
fdc5790
Compare
w3b6x9
force-pushed
the
fix/pooler-mode-transaction
branch
from
fdc5790
to
8554d86
Compare
w3b6x9
force-pushed
the
fix/pooler-mode-transaction
branch
from
8554d86
to
ccd9daa
Compare
joshenlim
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Project can't change pooler mode to session once in transaction mode.
Preview
When project is in transaction mode:
When project is in session mode:
Screen.Recording.2024-03-21.at.16.51.26.mov
Additional context
https://www.notion.so/supabase/Prevent-user-from-setting-Supavisor-pool-mode-when-in-transaction-mode-6fe2894127d443db88fe6f857ce740b4?pvs=4